Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add x64-gcc-12.3.0-glibc-2.28 #3

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

richardlau
Copy link
Collaborator

For Node.js 23 we're planning to update to building with gcc 12. This adds a crosstool-ng generated gcc 12 compiler (with the config included as part of this PR).

Refs: nodejs/build#3806

Built/tested locally: nodejs/build#3806 (comment)

Resultant Node.js 32-bit ARM binary built with the newly generated compiler is compatible with 32-bit ARM Ubuntu 22.04 and Debian 12 (but not with earlier Ubuntu 20.04 and Debian 11 due to libstdc++).

Planning to merge this tomorrow (I think I was given permission to do so last time we updated) so I can put the new compiler into containers on the Node.js CI to build/test there.

Copy link
Owner

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@richardlau richardlau merged commit 92391f6 into rvagg:master Sep 4, 2024
richardlau added a commit to nodejs/build that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants