pull in the latest datatables fix for triggering isArrayLike issue latest jquery causes

[dstull]

see here for the bug: jquery/jquery#2242

and here for the fix: DataTables/DataTablesSrc@485b259e5c02a

[dstull]

I've decided to just pull in datatables directly to my vendor/assets - seems to be working so far and is up to date. I'm not sure the value this gem provides, other than making install/maintenance easier. However, if it is not up to date/includes all data tables features, it usefulness diminishes...

[istana]

+1 because datatables cannot be used with new jQuery

[vicvega]

👍

[cknoxrun]

It's useful for me as I have it as a gem dependency in an engine. @dstull did you create a PR? If not I will.

[dstull]

I have not.

[mkhairi]

👍

[benoitwerner]

+1

[dometto]

👍 is anyone already working on a PR? @rweng, would you accept such a PR and cut a new release?

[pwim]

#204 updates the assets to 1.10.10, which has the fix for this issue. A new gem. 3.4.0, has also been issued. So I think this issue can be closed now.

[bartkamphorst]

Terrific! @pwim Thanks for letting us know. @TigerWolf Appreciate your efforts; thank you! 👍

[rweng]

@dometto sure, I am not actively maintaining this project right now, but pull-requests are always welcome and will be merged in. Might have to ping me once or twice about it, though, sometimes I loose track ;)

@pwin - yep, thank you, I'll close this off then

[pwin]

should have been an acknowledgement to @pwim
 -----Original Message-----From: notifications@github.hscsec.cnSent: Sat, 26 Mar 2016 02:33:59 -0700To: jquery-datatables-rails@noreply.github.hscsec.cnSubject: Re: [jquery-datatables-rails] pull in the latest datatables fix for triggering isArrayLike issue latest jquery causes (#193)@dometto sure, I am not actively maintaining this project right now, but pull-requests are always welcome and will be merged in. Might have to ping me once or twice about it, though, sometimes I loose track ;)

@pwin - yep, thank you, I'll close this off then

—You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub