Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for latest nightly #647

Closed
wants to merge 3 commits into from
Closed

Conversation

jebrosen
Copy link
Collaborator

@jebrosen jebrosen commented May 21, 2018

Resolves #646.

Includes fix for #643 on master branch.

This currently fails to compile, possibly because of rust-lang/rust#50942

* quote::Tokens is now proc_macro2::TokenStream
* syn::Ident now re-exports proc_macro2::Ident and no longer has
  AsRef<str>
@jebrosen
Copy link
Collaborator Author

Travis failed again; looks like diesel-rs/diesel#1722

diesel 1.3 currently fails to compile on nightly
@jebrosen
Copy link
Collaborator Author

I've pinned diesel to 1.2 in the todo example, since 1.3 doesn't currently compile on nightly. Tests pass locally, hopefully Travis is satisfied too.

@jebrosen
Copy link
Collaborator Author

We're back to found crate `rocket_codegen` compiled by an incompatible version of rustc [E0514]'. I had a similar error locally and was able to get around it by running cargo build before running the test suite.

@jebrosen jebrosen closed this May 29, 2018
@jebrosen jebrosen deleted the nightly-0520 branch May 29, 2018 17:05
@SergioBenitez
Copy link
Member

Merged in 00dd691.

@SergioBenitez SergioBenitez added the pr: merged This pull request was merged manually. label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures in Nightly due to Proc macro API 1.2 changes
2 participants