Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hasklig to v1.2 #555

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Conversation

Tehnix
Copy link
Contributor

@Tehnix Tehnix commented Jan 3, 2021

Description

The Hasklig recently released version 1.2 which addresses the issues outlined in microsoft/vscode#100840. The summary of that issue is that macOS Big Sur brought some subtle changes that meant that a lot of fonts broke in VSCode, showing only black text.

This PR brings the new version into nerd-fonts along with the patches applied to the new version.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Updates the Hasklig font to version 1.2, which brings important bug fixes.

How should this be manually tested?

Update your font and include it in VSCode. All now works.

Any background context you can provide?

Motivation behind the update, besides being up-to-date itself, is to fix microsoft/vscode#100840.

What are the relevant tickets (if any)?

microsoft/vscode#100840

Screenshots (if appropriate or helpful)

N/A

@ryanoasis ryanoasis merged commit a171bb6 into ryanoasis:master Apr 11, 2021
@Tehnix Tehnix deleted the hasklig-update-to-v1.2 branch April 11, 2021 12:36
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font is always black after installing macOS 11 (Source Code Pro font or derivatives need to be updated)
2 participants