Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argmap2mup output: .mup files appear blank in mindmup (opened from GDrive) #11

Open
s6mike opened this issue Jun 24, 2022 · 3 comments
Open

argmap2mup output: .mup files appear blank in mindmup (opened from GDrive) #11

s6mike opened this issue Jun 24, 2022 · 3 comments
Labels
bug Something isn't working fixed in branch Fixed in branch but not master

Comments

@s6mike
Copy link
Owner

s6mike commented Jun 24, 2022 •
edited
Loading

e.g. cat examples/example.yml | argmap2mup > example2.mup

Though they open fine using legacy open source version: mindmup/mapjs-webpack-example: simple example how to pack mapjs 2 with webpack
@s6mike s6mike added the bug Something isn't working label Jun 25, 2022
@s6mike
Copy link
Owner Author

s6mike commented Jul 2, 2022

example.mup works in mindmup, Example.mup doesn't.

example.mup from example/example.mup
Example.mup created from example/example.yml using argmap2mup.

See: 2 July: argmap_uploads - Google Drive

Plan: Compare the two and see what the difference is.

@s6mike
Copy link
Owner Author

s6mike commented Jul 2, 2022

These .mup files will still work with legacy mindmup however: mindmup/mapjs-webpack-example: simple example how to pack mapjs 2 with webpack.

@s6mike
Copy link
Owner Author

s6mike commented Oct 4, 2022

Fixed in argmap v4.8.13 on branch 12-argmapjs-fixes.

@s6mike s6mike added the fixed in branch Fixed in branch but not master label Oct 4, 2022
@s6mike s6mike pinned this issue Oct 4, 2022
s6mike added a commit that referenced this issue Oct 4, 2022
@s6mike
4.8.13 fix(lua): Now MindMup compatible :)
9eaff81 
- Files created from argmap2mup now work with Mindmup:
  - `src/argmap2mup.lua`:
    - Fix empty `"attr": {"parentConnector":` so it's omitted
  instead of having value [], which breaks mapjs logic.
      - Delete output `.json`/`.mup` files containing
    `"parentConnector": []`.
    - Change `default_to_nil()` to be local function (better practice).
- [README.md](../README.md): Update to reflect fix.

Fix #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed in branch Fixed in branch but not master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s6mike