Fix crash when Microsoft GS Wavetable Synth does not exist

sabihoshi · May 23, 2021 · b7bd01c · b7bd01c
1 parent c247105
commit b7bd01c
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/GenshinLyreMidiPlayer.WPF/GenshinLyreMidiPlayer.WPF.csproj b/GenshinLyreMidiPlayer.WPF/GenshinLyreMidiPlayer.WPF.csproj
@@ -6,7 +6,7 @@
     <UseWPF>true</UseWPF>
     <StartupObject>GenshinLyreMidiPlayer.WPF.App</StartupObject>
     <ApplicationManifest>app.manifest</ApplicationManifest>
-    <Version>2.0.1</Version>
+    <Version>2.0.2</Version>
     <ApplicationIcon>item_windsong_lyre.ico</ApplicationIcon>
     <Nullable>enable</Nullable>
     <RepositoryUrl>https://github.com/sabihoshi/GenshinLyreMidiPlayer</RepositoryUrl>

diff --git a/GenshinLyreMidiPlayer.WPF/ViewModels/LyrePlayerViewModel.cs b/GenshinLyreMidiPlayer.WPF/ViewModels/LyrePlayerViewModel.cs
@@ -31,7 +31,7 @@ public class LyrePlayerViewModel : Screen,
         private readonly IEventAggregator _events;
         private readonly MediaPlayer? _player;
         private readonly SettingsPageViewModel _settings;
-        private readonly OutputDevice _speakers;
+        private readonly OutputDevice? _speakers;
         private readonly PlaybackCurrentTimeWatcher _timeWatcher;
         private bool _ignoreSliderChange;
         private InputDevice? _inputDevice;
@@ -40,7 +40,6 @@ public class LyrePlayerViewModel : Screen,
         public LyrePlayerViewModel(IContainer ioc,
             SettingsPageViewModel settings, PlaylistViewModel playlist)
         {
-            _speakers    = OutputDevice.GetByName("Microsoft GS Wavetable Synth");
             _timeWatcher = PlaybackCurrentTimeWatcher.Instance;
 
             _events = ioc.Get<IEventAggregator>();
@@ -66,6 +65,18 @@ public LyrePlayerViewModel(IContainer ioc,
                 _player.CommandManager.PlayReceived  += async (_, _) => await PlayPause();
                 _player.CommandManager.PauseReceived += async (_, _) => await PlayPause();
             }
+
+            try
+            {
+                _speakers = OutputDevice.GetByName("Microsoft GS Wavetable Synth");
+            }
+            catch (ArgumentException e)
+            {
+                new ErrorContentDialog(e, closeText: "Ignore").ShowAsync();
+
+                _settings.CanUseSpeakers = false;
+                Settings.UseSpeakers     = false;
+            }
         }
 
         public BindableCollection<MidiInput> MidiInputs { get; } = new()
@@ -225,8 +236,11 @@ public void UpdateButtons()
 
         private void InitializeTracks()
         {
+            if (Playlist.OpenedFile?.Midi is null)
+                return;
+
             MidiTracks.Clear();
-            MidiTracks.AddRange(Playlist.OpenedFile?
+            MidiTracks.AddRange(Playlist.OpenedFile
                 .Midi.GetTrackChunks()
                 .Select(t => new MidiTrack(_events, t)));
         }
@@ -425,7 +439,7 @@ private void PlayNote(NoteEvent noteEvent)
         {
             if (Settings.UseSpeakers)
             {
-                _speakers.SendEvent(noteEvent);
+                _speakers?.SendEvent(noteEvent);
                 return;
             }
 

diff --git a/GenshinLyreMidiPlayer.WPF/ViewModels/SettingsPageViewModel.cs b/GenshinLyreMidiPlayer.WPF/ViewModels/SettingsPageViewModel.cs
@@ -45,6 +45,8 @@ public SettingsPageViewModel(IContainer ioc)
 
         public bool CanStartStopTimer => DateTime - DateTime.Now > TimeSpan.Zero;
 
+        public bool CanUseSpeakers { get; set; } = true;
+
         public bool IncludeBetaUpdates { get; set; } = Settings.IncludeBetaUpdates;
 
         public bool IsCheckingUpdate { get; set; }

diff --git a/GenshinLyreMidiPlayer.WPF/Views/SettingsPageView.xaml b/GenshinLyreMidiPlayer.WPF/Views/SettingsPageView.xaml
@@ -25,6 +25,7 @@
             <ui:SimpleStackPanel Orientation="Horizontal">
                 <ui:ToggleSwitch
                     Header="Test Mode (Speakers)"
+                    IsEnabled="{Binding CanUseSpeakers}"
                     IsOn="{Binding Default.UseSpeakers, Source={StaticResource Settings}}" />
 
                 <ui:ToggleSwitch