Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in "azerty" keys #8

Closed
shadowxdgamer opened this issue May 7, 2021 · 6 comments
Closed

Bug in "azerty" keys #8

shadowxdgamer opened this issue May 7, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@shadowxdgamer
Copy link

shadowxdgamer commented May 7, 2021

In azerty keys there is a small bug a "wrong letter" that should be changed
bug
well im not a programmer(im planning to learn in the near future ;D) and i dont know how to fix it and thought of informing you

Also is it possible to make a windows 7 version of the GenshinLyreMidiPlayer my friend has a windows 7 and i would like to try this tool with him playing duet songs. (as long as it does the main core thing that's good doesn't have to be polished or anything)

This tool is so good and so accurate good job on that, i will be making youtube videos and make sure to mention you in the description, also have a look at my request. Peace and have a good day 😉

@sabihoshi
Copy link
Owner

sabihoshi commented May 7, 2021

Thanks for reporting, I totally missed that.

And for Windows 7, does it not work there? Is there any error he gets when he tries to run it? It's published to win-x86 and win-x64 so it should work on Windows 7 as well. If he does get an error, what does it say? He might be missing the .Net Core 3.1 Runtime.

sabihoshi added a commit that referenced this issue May 7, 2021
@sabihoshi sabihoshi added bug Something isn't working good first issue Good for newcomers and removed good first issue Good for newcomers labels May 7, 2021
@sabihoshi
Copy link
Owner

If the error you're getting is missing the api-ms-win-crt-runtime-l1-1-0.dll, then you have to install Visual C++ Redistributable for Visual Studio (64-bit). If it does not want to install, then you have to install the update KB2999226 first.

@shadowxdgamer
Copy link
Author

Thank you for replying, actually no error shows up it straight up crashes i tried both x64 and x86 now with the same result

crash.mp4

I will try the both the two things you shared and tell you if it works after. i dont know if he has them installed
bug

Thanks again and if it doesn't work, there is no need to have a burnout over it :D

@shadowxdgamer
Copy link
Author

Hello quick update. i have just downloaded an old version and tested and it works :D

image

versions from 1.8.3 and below work. I think it has something to do with the new media control

image

I have thought of testing yoroshikun's Genshin Lyre Player and when it worked i had the idea to test the old versions

image

I think the issue is closed now :D, saddly the newer version 1.9.1 doesn't work and crashes

@sabihoshi
Copy link
Owner

Yeah that should do it, Windows 7 doesn't have the native Media Controls. I can just disable it when you're not running Windows 10, but in reality v1.9.1's new functionality is only the Media Controls so the older version should work the same way anyways.

Thank you for figuring it out! I'll implement a version where SMTC is disabled when not running Windows 10.

@shadowxdgamer
Copy link
Author

Okay, thanks and good luck on your future projects :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants