Add transaction deletion endpoint #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
requested changes
Jan 24, 2024
| DELETE_TRANSACTION_DTO_SCHEMA_ID, | ||
| deleteTransactionDtoSchema, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Nitpick: missing newline between functions 🙂
| ); | ||
| } | ||
| transform(data: unknown): DeleteTransactionDto { | ||
| return this.genericValidator.validate(this.isValid, data); |
There was a problem hiding this comment.
I think we should set the error status (400 - bad request) here, what do you think?
It's done that way in other ValidationPipes and I think it makes sense to communicate that a validation error at this level is a client-side error (400).
There was a problem hiding this comment.
Agreed. I've added it in 731824e but in a type safe way (adjusted in other PRs).
hectorgomezv
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
DELETEchains/:chainId/transactions/:safeTxHashendpoint for deleting transactions (in accordance with theDELETE/v1/transactions/{safe_tx_hash}endpoint of the Transaction Service) with associated test coverage.Changes
From "root" to call:
deleteTransactionhas been added to theTransactionApiandITransactionApiinterfacedeleteTransactionhas been added to theSafeRepositoryandISafeRepositoryinterfacedeleteTransactionhas been added to theTransactionsServiceDELETEchains/:chainId/transactions/:safeTxHashhas been added to theTransactionsController, accepting theDeleteTransactionDto(and validated by theDeleteTransactionDtoValidationPipe)DeleteTransactionDto
{ "signature": signature, }According to the Transaction Service, the above is used as follows:
An EOA is required to sign the following EIP712 data:
{ "types": { "EIP712Domain": [ {"name": "name", "type": "string"}, {"name": "version", "type": "string"}, {"name": "chainId", "type": "uint256"}, {"name": "verifyingContract", "type": "address"}, ], "DeleteRequest": [ {"name": "safeTxHash", "type": "bytes32"}, {"name": "totp", "type": "uint256"}, ], }, "primaryType": "DeleteRequest", "domain": { "name": "Safe Transaction Service", "version": "1.0", "chainId": chain_id, "verifyingContract": safe_address, }, "message": { "safeTxHash": safe_tx_hash, "totp": totp, }, }The
totpparameter is calculated with T0=0 and Tx=3600. It is calculated by taking the Unix UTC epoch time (without milliseconds) and dividing it by 3600 (natural division, no decimals).