Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

132 str trim not a function #209

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

awaterma
Copy link
Member

@awaterma awaterma commented Feb 5, 2021

I think this should provide a fix for issue #11, as well as I can tell. Please take a look.

@medelibero-sfdc @ruoho @ruoho-sfdc @ShivanKaul

Thanks!

@awaterma
Copy link
Member Author

@medelibero-sfdc -- I've updated the test and corrected parse validation based on that work. :) I think this is now ready to merge. We should wait on Travis; but everything passes locally.

Copy link
Contributor

@medelibero-sfdc medelibero-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awaterma awaterma merged commit 1b25269 into salesforce:master Apr 26, 2021
@awaterma awaterma deleted the 132-str-trim-not-a-function branch April 26, 2021 21:10
@awaterma
Copy link
Member Author

Merged this today after our meeting with @medelibero-sfdc and @ruoho-sfdc.

@awaterma
Copy link
Member Author

Referenced the incorrect issue above, this closes out #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants