Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows package testing #344

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Conversation

joshwlewis
Copy link
Collaborator

@joshwlewis joshwlewis commented Jan 19, 2022

What does this PR do?

Our latest release has failed with this error:

Screen Shot 2022-01-19 at 11 03 21 AM

This is due to an upstream bug in npm: npm/cli#4234.

According to https://salesforce-internal.slack.com/archives/C01LKDT1P6J/p1642612210084100, this issue does not occur with LTS node releases.

This PR changes the release-management/test-package Circle job to use windows/LTS instead of windows/latest, which should allow our release automation to work again.

This PR also bumps the minor version, since the automation failed on a2bd50c.

What issues does this PR fix or reference?

@W-10409382@

@uip-robot-zz
Copy link

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@joshwlewis joshwlewis changed the title Jwl/fix windows package testing chore: fix windows package testing Jan 19, 2022
Copy link
Contributor

@mimen mimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is, we should probably be updating the version to 1.5.0 rather than 1.5.3.

@joshwlewis
Copy link
Collaborator Author

Only thing is, we should probably be updating the version to 1.5.0 rather than 1.5.3.

Done in 6ad775f!

@joshwlewis joshwlewis merged commit 8582938 into main Jan 19, 2022
@joshwlewis joshwlewis deleted the jwl/fix-windows-package-testing branch January 19, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants