added getUniquePath function #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function to get a unique filename so we don't accidentally replace an existing file
saljam
reviewed
Nov 19, 2022
cmd/ww/file.go
Outdated
| // find a suitable filename to receive a file. if the path already exist, append a suffix or increment the existing suffix | ||
| func getUniquePath(path string) string { | ||
| newpath := path | ||
| suffixpattern := regexp.MustCompile(`\.(\d+)$`) |
|
i know it's been a while, but thanks for sending this in! i like the feature and i think we should definitely do this. i have 2 comments on how this is done however:
not specific to this, but a related idea: we should also add a suffix to files in progress, and rename them once they are complete. |
|
hey. yep, makes sense. I think at the time I was looking for MVP and see what you think. I'll push some changes to this before marking it as ready to merge |
|
changed the way it finds a new path and removed regex. added a few test cases below it too, but not sure if this function or the test suite should sit in the main package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to get a unique filename so we don't accidentally replace an existing file