Fix touchbar and add repost button to it. #233
Conversation
Impakt
commented
May 13, 2021
•
Impakt
commented
| soundcloud.repost() | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
The original PR included a reposted icon but no code associated with it. If there was a way to detect if a track has already been reposted we can update the icon, but i'm not sure how to do that.
app/touch-bar-menu.js
Outdated
| new TouchBarSpacer({ size: 'flexible' }) | ||
| ]) | ||
| const touchBar = new TouchBar({ | ||
| items:[ |
There was a problem hiding this comment.
this was the reason why the touchbar wasn't working earlier
Impakt
changed the title
Impakt
changed the title
Impakt
changed the title
|
@rmaes4 this may interest you |
app/touch-bar-menu.js
Outdated
| soundcloud.on('play', ({ title, subtitle }) => { | ||
| soundcloud.on('play-new-track', ({ title, subtitle, artworkURL }) => { | ||
| let displayTitle = `${title} by ${subtitle}` | ||
| displayTitle = displayTitle.padEnd(displayTitle.length * 1.3, ' ') |
There was a problem hiding this comment.
this seems hacky but it was the only way to not have the string truncated in the touch bar. You can now swipe on the scrubber to see the whole string
app/touch-bar-menu.js
Outdated
| }); | ||
| res.on('end', () => { | ||
| titleScrubber.items = [{ | ||
| label:'' |
There was a problem hiding this comment.
this stops the artwork from having rounded corners on the left hand side
|
@Impakt Awesome! I am quite busy these days and haven't worked on this project in a long time but it is great to see more progress. |
|
Kudos, SonarCloud Quality Gate passed!
|
