-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not reference __dirname if it does not exist #1168
Conversation
Please note that I'm in a vacation mode, I can do GitHub stuff, but I might not contribute code right now actively |
@PatKayongo The current configuration (CommonJS) of the test cases don't like your solution, unfortunately. This SO post may be relevant (more specifically, its top-rated answer). You may simply be able to configure Update: |
@PatKayongo What I mention in my previous post gets us over the hurdle, but only on to the next issue. You'll notice that the Thankfully, the solution to this also lies within the We're then left facing one last hurdle. Now that we've injected (effectively) a Note: This all just seems..... like a very hacky fix. While it is safe enough (in my opinion) for a bug fix under v7.x of Research: My findings come primarily from this thread and, specifically, this post. |
I plan to go esm first in v8 and drop cjs support in v9 |
@Shinigami92 That is wonderful news! For the time being, the changes I've posted above seem to take care of the issue. I cloned and tested locally and can confirm that the JavaScript migration files (if named |
This is what I meant with v8 🙂 |
This was partially taken over in #1187 |
The purpose of this is to fix issue #1167
For esmodules, it doesn't use
__dirname
to get the current module directory location, as this is not available.