Add support for Omniauth OpenID Connect login. #2953
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value for client_auth_method is 'query' in the example, but default value is 'basic' as described in [GitLab OmniAuth OIDC documentation, step 4.](https://docs.gitlab.com/ee/administration/auth/oidc.html).
|
I found the following differences between my request (#2953) and #2927:
|
sachilles
reviewed
Jun 21, 2024
| OAUTH_OIDC_RESPONSE_TYPE=${OAUTH_OIDC_RESPONSE_TYPE:-'code'} | ||
| OAUTH_OIDC_ISSUER=${OAUTH_OIDC_ISSUER:-} | ||
| OAUTH_OIDC_DISCOVERY=${OAUTH_OIDC_DISCOVERY:-true} | ||
| OAUTH_OIDC_CLIENT_AUTH_METHOD=${OAUTH_OIDC_CLIENT_AUTH_METHOD:-'basic'} |
There was a problem hiding this comment.
In https://docs.gitlab.com/ee/administration/auth/oidc.html the default value for client_auth_method (OAUTH_OIDC_CLIENT_AUTH_METHOD) is 'query'. Does tis matter?
There was a problem hiding this comment.
In https://docs.gitlab.com/ee/administration/auth/oidc.html under step 4, supported values for client_auth_method are listed: basic, jwt_bearer, mtls, Any other value posts the client ID and secret in the request body. If not specified, this value defaults to basic. However query is written in the examples. Finally, I decided to use the basic value.
sachilles
reviewed
Jun 21, 2024
README.md
Outdated
Comment on lines
735
to
749
| | GitLab setting | environment variable | | ||
| |----------------|----------------------| | ||
| | `label` | `OAUTH_OIDC_LABEL` | | ||
| | `icon` | `OAUTH_OIDC_ICON` | | ||
| | `scope`| `OAUTH_OIDC_SCOPE` | | ||
| | `response_type` | `OAUTH_OIDC_RESPONSE_TYPE` | | ||
| | `issuer` | `OAUTH_OIDC_ISSUER` | | ||
| | `discovery` | `OAUTH_OIDC_DISCOVERY` | | ||
| | `client_auth_method` | `OAUTH_OIDC_CLIENT_AUTH_METHOD` | | ||
| | `uid_field` | `OAUTH_OIDC_UID_FIELD` | | ||
| | `send_scope_to_token_endpoint` | `OAUTH_OIDC_SEND_SCOPE_TO_TOKEN_EP` | | ||
| | `pkce` | `OAUTH_OIDC_PKCE` | | ||
| | `client_options.identifier` | `OAUTH_OIDC_CLIENT_ID` | | ||
| | `client_options.secret` | `OAUTH_OIDC_CLIENT_SECRET` | | ||
| | `client_options.redirect_uri` | `OAUTH_OIDC_REDIRECT_URI` | |
There was a problem hiding this comment.
Could you be so kind and add the default values defined in assets/runtime/functions? I guess, this will be helpful.
…now listed in README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables OpenID Connect OmniAuth authentication method in GitLab. OmniAuth OIDC documentation