Should characterize be kicked off by Sufia::GenericFile::Actions.create_content?

[jcoyne]

Then we can remove the around_save :characterize_if_changed from GenericFile.

This makes the code easier to follow.

[mjgiarlo]

Not having my head in the code lately, I ask what may be an obvious question: can we rely upon Actions.create_content getting called, or are there other paths around it? Put otherwise, the advantage of a hook is that it "just works" on save.

[jcoyne]

@mjgiarlo Aye, the huge advantage is that we know it works. Another drawbacks is that it is slowing down our system considerably, because it's always checks for content change on every save. We can shoulder some of that responsibility as coders by agreeing that we always deposit files via the Sufia::GenericFile::Actions.create_content service method.