Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposited Files count on Profile Page is sum of files + collections + batches #454

Closed
kerchner opened this issue May 20, 2014 · 4 comments · Fixed by #526
Closed

Deposited Files count on Profile Page is sum of files + collections + batches #454

kerchner opened this issue May 20, 2014 · 4 comments · Fixed by #526

Comments

@kerchner
Copy link
Contributor

Number of files and collections should be broken out separately, rather than showing the total (+ batches) as number of files

@mjgiarlo
Copy link
Member

mjgiarlo commented Jun 3, 2014

This is about to change drastically as the new dashboard layout is rolled out. We should confirm this is still true in the 4.0.0 release when it comes out (any day now).

@awead
Copy link
Contributor

awead commented Jun 16, 2014

Relevant method is here:
https://github.com/projecthydra/sufia/blob/master/app/helpers/sufia/sufia_helper_behavior.rb#L46
which hasn't changed in 4.0.0 so the problem remains.
A simple fix would be to just change this to:

GenericFile.where(Solrizer.solr_name('depositor', :stored_searchable) => user.user_key).count

for files and

Collections.where(Solrizer.solr_name('depositor', :stored_searchable) => user.user_key).count

for collections.
I'm not sure if show numbers of batches would be that useful, but I can add it if you like.

@awead
Copy link
Contributor

awead commented Jun 16, 2014

@mjgiarlo also, wouldn't batches appear under Notifications?

@mjgiarlo
Copy link
Member

IMO, we should not reflect the # of batches since users don't even know they exist in the system.

awead added a commit that referenced this issue Jun 17, 2014
@awead awead mentioned this issue Jun 17, 2014
awead added a commit that referenced this issue Jun 17, 2014
jcoyne pushed a commit that referenced this issue Nov 17, 2016
Initialize required variables when failing to update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants