Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): create a test studio for e2e tests #5044

Merged
merged 6 commits into from
Oct 26, 2023
Merged

chore(e2e): create a test studio for e2e tests #5044

merged 6 commits into from
Oct 26, 2023

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 23, 2023

Description

This PR creates a new studio instance that is inheriting the schema from the test studio but works in isolation with the idea being this studio is solely used for e2e testing. This studio also takes the projectId and dataset as env variables with the idea being that we would create a new dataset per PR which is removed after the PR is merged (future PR for this) this makes sure that the tests are run in true isolation and not affected by any side effects during development or testing.

Other changes in this PR is that now the e2e tests in CI run on the production build of the studio which removes the CI flakyness out of the equation trying to serve a page. Since it would be the production build it should also match very closely to what is deployed.

What to review

  • Imports in studio-e2e-testing makes sense. Specifically here

Notes for release

  • N/A

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 26, 2023 4:54pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:54pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:54pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Component Testing Report Updated Oct 26, 2023 4:56 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 8s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 23s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 12s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 49s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@binoy14 binoy14 marked this pull request as ready for review October 23, 2023 17:53
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! LGTM

@binoy14 binoy14 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into next with commit 2d58099 Oct 26, 2023
29 checks passed
@binoy14 binoy14 deleted the sdx-790 branch October 26, 2023 17:03
skogsmaskin pushed a commit that referenced this pull request Nov 2, 2023
* chore(e2e): create a test studio for e2e tests

* chore(e2e): use correct token

* chore(e2e): add basePath to testing studio

* chore(e2e): use test-studio as a dependency cleanup packages

* chore(e2e): remove unused dependency

* chore(e2e): run e2e tests in production build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants