feat(i18n): allow simple HTML tags when using Translate component #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
|
Component Testing Report Updated Nov 3, 2023 6:13 PM (UTC)
|
bjoerge
approved these changes
Nov 3, 2023
| ) | ||
| }) | ||
| test('tags cant contain whitespace or special characters', () => { | ||
| expect(() => simpleParser('foo <Em@ail> bar</Em@ail>')).toThrow( | ||
| 'Invalid tag "<Em@ail>". Tag names must start with an uppercase letter and can only include letters and numbers.', | ||
| 'Invalid tag "<Em@ail>". Tag names must be lowercase HTML tags or start with an uppercase letter and can only include letters and numbers.', |
There was a problem hiding this comment.
should we mention the subset of tags we allow here?
|
|
||
| throw new Error( | ||
| tagName.trim() === tagName | ||
| ? `Invalid tag "<${tagName}>". Tag names must be lowercase HTML tags or start with an uppercase letter and can only include letters and numbers.` |
There was a problem hiding this comment.
re:previous comment: maybe this would be a better place to mention what subset of tags we allow?
There was a problem hiding this comment.
Maybe. It does print an error in the Translate component, so I think that is fine for now. I tried refactoring, but ran into some parser shenanigan holes that I don't want to reason about at the moment. We can get back to it later if it becomes a problem.
rexxars
force-pushed
the
feat/i18n-allow-basic-html-tags
branch
from
cf327ca
to
f87050f
Compare
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
rexxars
added a commit
that referenced
this pull request
Nov 17, 2023
rexxars
added a commit
that referenced
this pull request
Nov 20, 2023
rexxars
added a commit
that referenced
this pull request
Nov 22, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 27, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 28, 2023
rexxars
added a commit
that referenced
this pull request
Nov 28, 2023
rexxars
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a bit tedious to pass in components like
<Code>that just maps to<code>. This PR allows using this predefined list of tags without specifying it directly:<abbr>,<address>,<cite>,<code>,<del>,<em>,<ins>,<kbd>,<q>,<samp>,<strong>,<sub>,<sup>.The reason for these specifically is that they are inline elements that do not require any attributes for use, and is not deprecated by the HTML5 spec.
I'm not sure if my solution in the parser was the best, but I didn't want to spend more time finding a more elegant way to approach it - open to suggestions.
What to review
<Translate/>component works as it shouldNotes for release
None.