fix(cli): use inferred project root when creating migrations from subdirectory #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Mar 13, 2024 5:06 PM (UTC)
|
cngonzalez
approved these changes
Mar 7, 2024
packages/sanity/src/_internal/cli/commands/migration/createMigrationCommand.ts
Show resolved
Hide resolved
packages/sanity/src/_internal/cli/commands/migration/createMigrationCommand.ts
Show resolved
Hide resolved
juice49
force-pushed
the
fix/create-migrations-from-subdirectory
branch
from
71dea59
to
b5afac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When used inside a Studio project subdirectory, the CLI searches parent directories in order to infer the project root. The
migration createcommand doesn't currently respect the inferred root, and will attempt to create/use amigrationsdirectory in the current working directory. This behaviour is incorrect; it's impossible to run migrations located anywhere other than themigrationsdirectory in the project root.This branch makes
migration createcommand respect the inferred project root.What to review
Does this fix make sense?
Testing
Attempt to create a migration from a Studio project subdirectory. The migration should always be added to the
migrationsdirectory in the project root.