fix(cli): add note about webhooks in migration run command #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 4, 2024 7:53 PM (UTC)
|
juice49
reviewed
Mar 22, 2024
There was a problem hiding this comment.
The CLI has the ability to list project webhooks (sanity hook list). It may be out of scope at this time, but it could be helpful to automatically check for active webhooks as part of the migration process, and only print a warning if any exist. This would be yet another guard rail that makes migrations safer than executing scripts directly.
packages/sanity/src/_internal/cli/commands/migration/runMigrationCommand.ts
Outdated
Show resolved
Hide resolved
packages/sanity/src/_internal/cli/commands/migration/runMigrationCommand.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SDX-1156
Description
Adds a message to warn users that migrations will trigger web hooks.
What to review
Is this the right message?
Testing
No behavioral change
Notes for release