Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): don't open tasks search on hotkey + enter #6165

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Apr 2, 2024

Description

Fixes an issue in which when tasks panel is open, cmd + K search changes target document rather than searches the studio.
This happens because the SearchPopover takes a onOpen prop which is triggered by the useSearchHotkey hook. Producing an undesired effect of opening by duplicated the search popover when tasks is open. Actually triggering the changes of the task form instead of the search change.

Making this prop optional, and not passing it through from the TargetField fixes the issue.

What to review

Testing

Notes for release

Fixes an issue in which when the tasks panel is open, cmd + K search changes target document rather than searches the studio.

@pedrobonamin pedrobonamin requested a review from a team as a code owner April 2, 2024 13:21
@pedrobonamin pedrobonamin requested review from hermanwikner and removed request for a team April 2, 2024 13:21
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 2, 2024 1:23pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 1:23pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Apr 2, 2024 1:23pm

Copy link
Contributor

github-actions bot commented Apr 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Component Testing Report Updated Apr 2, 2024 1:32 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Member

@sjelfull sjelfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@pedrobonamin pedrobonamin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into next with commit d387316 Apr 2, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the edx-1223 branch April 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants