fix(tasks): don't open tasks search on hotkey + enter #6165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in which when tasks panel is open, cmd + K search changes target document rather than searches the studio.
This happens because the SearchPopover takes a
onOpen
prop which is triggered by theuseSearchHotkey
hook. Producing an undesired effect of opening by duplicated the search popover when tasks is open. Actually triggering the changes of the task form instead of the search change.Making this prop optional, and not passing it through from the
TargetField
fixes the issue.What to review
Testing
Notes for release
Fixes an issue in which when the tasks panel is open, cmd + K search changes target document rather than searches the studio.