-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support strict: true
in @sanity/schema
codebase
#6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
stipsan
force-pushed
the
use-strict-on-schema
branch
from
April 4, 2024 08:08
30201ad
to
d9b6263
Compare
No changes to documentation |
Component Testing Report Updated Apr 4, 2024 8:17 AM (UTC)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was done in #5983 and is required for #5983 to land. But as that PR is already quite large it's split up into its own PR to reduce the cognitive load for reviewers.
The objective is first and foremost to remove the requirement for these in the tsconfig for
@sanity/schema
:so that all our packages use the same compiler settings and can be used with
compilerOptions.paths
for IDE and language service features that can typecheck code between packages without first needing to save the file, or build the package.Note that this
compilerOptions.paths
setup is implemented in #5983, this PR lays the groundwork for it.What to review
Everything should continue to build, this is a TS concern and generated JS should be identical.
Testing
If the CI pass we're good, no manual testing needed.
Notes for release
N/A