fix(cli): ensure output path for types exist before writing #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 9, 2024 10:59 PM (UTC)
|
jtpetty
reviewed
Apr 9, 2024
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "schema": "./working-schema.json" | |||
| "schema": "./working-schema.json", | |||
| "generates": "./out/types.ts" | |||
There was a problem hiding this comment.
we probably should have a test with a directory and one without a directory, but otherwise, 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
generatespath in the typegen configuration points to a path that does not exist, it will crash with aENOENT: no such file or directory, open '<some-path>/<generates-path>'error.This PR fixes this by running a recursive directory creation process before writing the output file.
What to review
Testing
Added a CLI test to reproduce - the
outdirectory does not exist in the fixture, and thus should fail before this change and pass after this change.Notes for release
sanity typegen generatewould crash if the configured output path did not exist prior to running the command