Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support IDE's using older TypeScript versions on the monorepo #6308

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Apr 10, 2024

Unless your IDE, like VS Code, is set to use the monorepo version of TypeScript it might load the one it's bundled with. Which might not be 5.4 which is required to understand module: "Preserve". This PR sets the other options moduleResolution, esModuleInterop and resolveJsonModule to what module: "Preserve" is using, to make sure everything still works

@stipsan stipsan requested a review from a team as a code owner April 10, 2024 10:59
@stipsan stipsan requested review from jtpetty and removed request for a team April 10, 2024 10:59
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 10, 2024 10:59am
test-studio ✅ Ready (Inspect) Visit Preview Apr 10, 2024 10:59am
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Apr 10, 2024 10:59am

@stipsan stipsan enabled auto-merge April 10, 2024 10:59
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Apr 10, 2024 11:06 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 24s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@stipsan stipsan added this pull request to the merge queue Apr 11, 2024
Merged via the queue into next with commit a4e097f Apr 11, 2024
37 checks passed
@stipsan stipsan deleted the support-older-TS-in-IDEs branch April 11, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants