Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): fix unawaited assertion #6442

Merged
merged 1 commit into from
Apr 22, 2024
Merged

test(e2e): fix unawaited assertion #6442

merged 1 commit into from
Apr 22, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Apr 22, 2024

Description

Fixes an e2e test that was improperly awaiting its assertions, sometimes causing the test to timeout.

What to review

That the test/e2e/tests/desk/deprecatedFields.spec.ts test runs correctly.

@juice49 juice49 requested a review from a team as a code owner April 22, 2024 09:01
@juice49 juice49 requested review from ricokahler and removed request for a team April 22, 2024 09:02
@vercel Vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 22, 2024 9:02am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 9:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Apr 22, 2024 9:02am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Apr 22, 2024 9:09 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

binoy14
binoy14 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid find, thank you!

@juice49 juice49 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into next with commit 37b6291 Apr 22, 2024
37 checks passed
@juice49 juice49 deleted the fix/e2e-deprecated-fields branch April 22, 2024 22:58
jordanl17 pushed a commit that referenced this pull request Apr 23, 2024
@juice49 @jordanl17
test(e2e): fix unawaited assertion (#6442)
0531a5f
cngonzalez pushed a commit that referenced this pull request May 8, 2024
@juice49 @cngonzalez
test(e2e): fix unawaited assertion (#6442)
2314699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binoy14 binoy14 binoy14 approved these changes

@ricokahler ricokahler Awaiting requested review from ricokahler ricokahler is a code owner automatically assigned from sanity-io/studio-dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juice49 @binoy14