fix(core): remove id from patch when using server actions #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bjoerge
commented
May 23, 2024
| @@ -149,7 +149,9 @@ export default defineConfig([ | |||
| basePath: '/test', | |||
| icon: SanityMonogram, | |||
| // eslint-disable-next-line camelcase | |||
| __internal_serverDocumentActions: {}, | |||
| __internal_serverDocumentActions: { | |||
| enabled: true, | |||
There was a problem hiding this comment.
wasn't aware we had turned it off, so turning it on again here
bjoerge
force-pushed
the
fix/remove-id-from-patch-when-using-server-actions
branch
from
0abd48f
to
7ad4196
Compare
|
No changes to documentation |
|
Component Testing Report Updated May 23, 2024 12:46 PM (UTC)
|
bjoerge
force-pushed
the
fix/remove-id-from-patch-when-using-server-actions
branch
from
7ad4196
to
542f205
Compare
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using server actions, we forwarded the patch mutations as-is, but that means they would also include the document id. The doucment ID is alredy provided as part of the actions payload, and should not be part of the action's patch here.
What to review
The diff :)
Testing
This was already covered by a test that I've updated.
Notes for release
N/A