fix: handle circular import issue in a compiler friendly way #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
stipsan
force-pushed
the
fix-preview-card-compiler-issue
branch
from
240b325
to
7ef7ac1
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sanity/telemetry@0.7.9, npm/@sanity/test@0.0.1-alpha.1, npm/@sanity/tsdoc@1.0.67, npm/@sanity/ui-workshop@1.2.11, npm/@sanity/ui@2.1.14, npm/@sanity/uuid@3.0.2, npm/@sanity/visual-editing@2.1.2, npm/@tanstack/react-table@8.16.0, npm/@tanstack/react-virtual@3.0.0-beta.54, npm/@testing-library/jest-dom@6.4.2, npm/@testing-library/react@13.4.0, npm/@testing-library/user-event@13.5.0, npm/semver@7.6.2 |
|
Component Testing Report Updated May 30, 2024 2:29 PM (UTC)
|
binoy14
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By moving the import to colocate with the
StyledCarddefinition we're able to avoid the circular deps issue in CJS, and regain the benefit of declaring thestyled(PreviewCard)on the top-level instead of at runtime in that the CSS is known ahead of time forstyled-components.What to review
It makes sense what it's named and its internal warning.
Testing
I tested it manually, but I'm not familiar with the original cjs bundle issue being referred to, can @bjoerge advice?
Notes for release
N/A as it's an internal refactor that allows React Compiler but is otherwise the same as before