Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): allow using auto-updates in unattended mode #6897

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix(cli): allow using auto-updates in unattended mode #6897

merged 2 commits into from
Jun 11, 2024
+6 −2

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Jun 11, 2024 •
edited
Loading

Description

Respects unattended mode when using auto-updates flag

What to review

npx sanity build --auto-updates

If not using unattended mode it will default to no

npx sanity build --auto-updates -y

If using unattended mode it will default to yes and not show the prompt

Testing

Don't have specific tests for this, I will make a follow up PR to add tests for build command with auto-updates in general

Notes for release

N/A

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:50pm
performance-studio ✅ Ready (Inspect) Visit Preview Jun 11, 2024 9:50pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:50pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:50pm

This was referenced Jun 11, 2024
Merged
Closed
@binoy14 Graphite App
Copy link
Contributor Author

binoy14 commented Jun 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite Graphite

@binoy14 binoy14 mentioned this pull request Jun 11, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@binoy14 binoy14 marked this pull request as ready for review June 11, 2024 19:25
@binoy14 binoy14 requested a review from a team as a code owner June 11, 2024 19:25
@binoy14 binoy14 requested review from cngonzalez and removed request for a team June 11, 2024 19:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

Component Testing Report Updated Jun 11, 2024 9:55 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 38s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 19s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

cngonzalez
cngonzalez previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@cngonzalez cngonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change in copy! I also found this confusing until we updated.

From a glance this looks fine, and I'll look ahead to PRs that include tests.

Base automatically changed from sdx-1259 to next June 11, 2024 21:39
@binoy14 binoy14 dismissed cngonzalez’s stale review June 11, 2024 21:39

The base branch was changed.

rexxars
rexxars previously approved these changes Jun 11, 2024
View reviewed changes
packages/sanity/src/_internal/cli/commands/build/buildCommand.ts Outdated Show resolved Hide resolved
@binoy14 @rexxars
chore(cli): Update copy for build command unattended mode
640c1ca 
Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com>
@binoy14 binoy14 requested a review from rexxars June 11, 2024 21:45
@binoy14 binoy14 added this pull request to the merge queue Jun 11, 2024
Merged via the queue into next with commit 61f1f8c Jun 11, 2024
42 of 43 checks passed
@binoy14 binoy14 deleted the sdx-1392 branch June 11, 2024 21:54
@leocabrallce leocabrallce mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

@cngonzalez cngonzalez Awaiting requested review from cngonzalez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binoy14 @rexxars @cngonzalez