-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement basic error reporting #6914
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
525e711
to
3a947c2
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
No changes to documentation |
Component Testing Report Updated Jun 17, 2024 2:58 PM (UTC)
|
3a947c2
to
08e0666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and tested in different situations and seems to be piping correctly. There is opportunity to improve source map detection but that can be follow up PRs. There seems to be a linting error and merge conflict. Once that is fixed happy to ✅ it
08e0666
to
900dd5f
Compare
900dd5f
to
999832a
Compare
Rebased, lint and tests passing |
999832a
to
f203083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
This introduces an error reporter using Sentry, for auto-updating, non-embedded studios. In the future, we may extend this to other studio types/configurations.
Review notes
SANITY_VERSION
constant from being a static0.0.0-development
to say3.15.3-development
. This is really only relevant for the monorepo, but is helpful in the context of error reporting to see what the "base" version is.undefined
or similar)setTimeout
/setImmediate
/setInterval
)Testing
We're currently missing tests. I'd like to add some playwright tests that trigger an error and verify that a network request to the Sentry relay is triggered, but have not had time yet. Will see if I can find time before merging this.
Notes for release
None, I think. Will double check if this should be called out or not.