refactor(sanity): move bundle metadata store to resource cache #7077
+345
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
RitaDias
reviewed
Jul 8, 2024
There was a problem hiding this comment.
@juice49 forgive me if I'm mixing concepts: would it be here that we should do the fetch for the existing versions of documents like @pedrobonamin brought up as a question in an earlier PR?
There was a problem hiding this comment.
This bundles store fetches the bundle documents from the addon dataset only.
We will need to fetch the version documents from other location, because we could in theory have a version document without a bundle
|
Left a comment! |
pedrobonamin
reviewed
Jul 8, 2024
pedrobonamin
reviewed
Jul 8, 2024
pedrobonamin
reviewed
Jul 8, 2024
pedrobonamin
reviewed
Jul 8, 2024
juice49
force-pushed
the
feat/resource-cache-bundle-metadata-store
branch
from
6236a7d
to
aab7b2e
Compare
juice49
force-pushed
the
feat/resource-cache-bundle-metadata-store
branch
from
aab7b2e
to
48f20f3
Compare
|
No changes to documentation |
juice49
force-pushed
the
feat/resource-cache-bundle-metadata-store
branch
from
48f20f3
to
e9be93f
Compare
juice49
force-pushed
the
feat/resource-cache-bundle-metadata-store
branch
from
e9be93f
to
f9aafec
Compare
Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>
juice49
force-pushed
the
feat/resource-cache-bundle-metadata-store
branch
from
f9aafec
to
cbf7da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch moves the bundle metadata store to the resource cache and removes the
BundlesContextcontext, which is no longer required.The bundle metadata store is initialised lazily when first subscribed to. Upon subscription, it will fetch a list of bundles and create a listener to keep the locally held state fresh.
The store is not disposed of when all subscriptions are closed. After it has been initialised, it will keep listening for the duration of the app's lifecycle. Subsequent subscriptions will be given the latest state upon subscription.
Note: the
packages/sanity/src/core/releases/tool/__tests__/BundlesOverview.test.tsxtest is failing, but this seems to have been occurring prior to the change.What to review
Testing
Notes for release