Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove self imports #7125

Closed
wants to merge 1 commit into from

Conversation

ricokahler
Copy link
Contributor

Description

This PR removes self imports to the 'sanity' module within the packages/sanity/src/core folder. We have an ESLint plugin that is supposed to catches these but it doesn't seems like that's working.

What to review

Review the imports and see if I missed anything.

Testing

I ran the test studio and ran the build.

Notes for release

N/A - internal change only

@ricokahler ricokahler requested review from a team as code owners July 10, 2024 14:44
@ricokahler ricokahler requested review from jordanl17 and cngonzalez and removed request for a team July 10, 2024 14:44
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:33pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:33pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:33pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:33pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 4:33pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Component Testing Report Updated Jul 10, 2024 4:39 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 36s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 4s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 36s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 19s 3 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant