fix(sanity): open correct groups and fieldsets on setOpenPath
#7154
+214
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jul 15, 2024 7:17 PM (UTC)
|
rdunk
force-pushed
the
fix/form-expand-operations
branch
from
e53ddfa
to
f966d62
Compare
rdunk
force-pushed
the
fix/form-expand-operations
branch
from
f966d62
to
22e058f
Compare
rdunk
force-pushed
the
fix/form-expand-operations
branch
2 times, most recently
from
a7ccfe6
to
7db67ad
Compare
rdunk
force-pushed
the
fix/form-expand-operations
branch
from
7db67ad
to
7c325af
Compare
rdunk
force-pushed
the
fix/form-expand-operations
branch
from
7c325af
to
378be0c
Compare
rdunk
force-pushed
the
fix/form-expand-operations
branch
from
378be0c
to
b19b14d
Compare
rdunk
changed the title
setOpenPath
This was referenced Aug 7, 2024
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For context, this PR is to resolve issues largely reported by Presentation users. I believe the same issue affects the Structure tool, but is far less visible as this is a less common scenario and largely non-critical in that context.
In summary:
setOpenPathin theDocumentPaneProviderfails to focus the specified field if it exists in non-default groups or collapsed fieldsets.This is because
getExpandOperationsis not returning the expected operations, which in turn seems to be becauseimmutableReconciledrops the_allMembersproperty of the form state as it currently only handles enumerable properties (and_allMembersis explicitly set to non-enumerable).There is also a small change to
getExpandOperationsas I believe thesetSelectedGroupoperation was returning the wrong group name.What to review
The simplest way to reproduce the issue in Structure is by clicking on the global presence avatar of a user who is currently focused on a field in a non-default group or collapsed fieldset.
This PR also adds a new schema type and an update to the Presentation test studio preview (under the
FieldGroupstab) useful for checking the focus behaviour of non-default groups and collapsed fieldsets.Testing
One test added to check that
immutableReconcilealways returns the latest value of non-enumerable properties.Notes for release