Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove agressive npmrc options #7282

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: remove agressive npmrc options #7282

merged 1 commit into from
Jul 31, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jul 30, 2024

Description

Looks like some of the options we set doesn't play too nice with pnpm dedupe, as seen in #7281.
I've removed them and set us to trust the defaults, except for prefer-workspace-packages and link-workspace-packages = deep as they make a lot of sense for our monorepo setup.

What to review

It makes sense?

Testing

Existing tests should be enough. I ran pnpm dedupe && pnpm install --fix-lockfile locally before pushing.

Notes for release

N/A

@stipsan stipsan requested a review from a team as a code owner July 30, 2024 15:06
@stipsan stipsan requested review from binoy14 and removed request for a team July 30, 2024 15:06
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:59pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:59pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:59pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:59pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:59pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jul 30, 2024 5:06 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 24s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 45s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 19s 3 0 0

@stipsan stipsan added this pull request to the merge queue Jul 31, 2024
Merged via the queue into next with commit 8e99272 Jul 31, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants