refactor: flatten _singletons and increase usage of sanity/_createContext
#7311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ricokahler
changed the title
_singletons and increase usage of sanity/_createContext
ricokahler
force-pushed
the
refactor/global-context
branch
from
d0166c3
to
03294df
Compare
|
No changes to documentation |
|
Component Testing Report Updated Aug 3, 2024 3:25 AM (UTC)
|
stipsan
approved these changes
Aug 3, 2024
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
…Context` (#7311) * chore: add eslint rule to prevent react.createContext * refactor: move and flatten contexts * refactor: switch to sanity/_createContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one is a follow up for @stipsan's #7160.
This PR:
_singletonsfolder structure. Previously, this folder mirrored our core folder structure, but this nesting was unnecessary given the global nature of these React contexts. Each context has a single, global key and is exported from'sanity/_singletons'. Flattening the structure should simplify things and improve discoverability of contexts, and aligns the file system organization with how these contexts are used and exported.createContextfrom 'react'tosanity/_createContext. This should prevent errors due to pnpm installing the same version of'sanity'` more than once.createContextfrom'react'NOTE: review the last commit for an easier review
What to review
Did I miss anything? Does everything look alright?
I wrote a small script for this refactor.
Testing
Ran type check and ensured all of the previous contexts that were exported were still being exported.
Notes for release
sanity/_createContext, reducing potential "missing context" errors in certain environments.