Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typegen): add location of discovered query #7327

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Aug 6, 2024

Description

Adds a location object to the discovered queries, this is practical when using codegen to parse a source file and find location of queries. Ie in vscode-sanity

What to review

Does the start/end interface make sense?

Testing

Added

Notes for release

N/A - no notes needed

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:07am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:07am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:07am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:07am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Aug 6, 2024 11:07am

@sgulseth sgulseth marked this pull request as ready for review August 6, 2024 10:13
@sgulseth sgulseth requested a review from a team as a code owner August 6, 2024 10:13
Copy link
Contributor

github-actions bot commented Aug 6, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Component Testing Report Updated Aug 6, 2024 11:14 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 13s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 47s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 19s 3 0 0

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, refusing to bike shed on the naming. After writing plugins in babel, ESLint, etc etc etc there isn't really a consensus anyway on exact naming 😄

@sgulseth sgulseth added this pull request to the merge queue Aug 6, 2024
Merged via the queue into next with commit d77e3ad Aug 6, 2024
42 checks passed
@sgulseth sgulseth deleted the feat/typegen/add-location branch August 6, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants