fix(core): update eslintrc config to show no-restricted-imports rules

[pedrobonamin]

Description

The existing eslint config is overriding the original no-restricted-imports rule.
When this rule was added:

'no-restricted-imports': [
          'error',
          {
            paths: [
              {
                name: 'react',
                importNames: ['createContext'],
                message: 'Please place context in _singletons',
              },
            ],
          },

The previous rules stopped working.

• This PR introduces changes to make all the no-restricted-imports rules work at the same time.
• This PR also fixes the failing checks, by either importing the corresponding files or opting out where needed.

With the changes introduced, now we are seeing all the expected errors.

What to review

• Are this changes ok?
• Is there any way to configure the eslint file to expose different error messages for React default import error and context error ?
• Small caveat: The error for "Please place context in _singletons" is not standalone anymore, it's shared with the React default error.

Testing

Create a .tsx file inside packages/sanity/* and add the following code, the errors should show in the file and when running the lint check action.

import {Button} from '@sanity/ui'
import React, {createContext} from 'react'
import styled from 'styled-components'

const StyledButton = styled(Button)`
  padding: 10px;
`
const context = createContext(null)

export function Test() {
  const [count, setCount] = React.useState(0)
  return <StyledButton onClick={() => setCount(count + 1)} text={`count: ${count}`} />
}

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 8:00am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 8:00am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 8:00am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 8:00am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 8:00am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Aug 14, 2024 8:00am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Aug 14, 2024 8:07 AM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	45s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	30s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	36s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	17s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 43s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 15s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	8s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	25s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	1m 22s	20	0	1
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	1m 47s	30	0	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	20s	3	0	0

[pedrobonamin]

This is the default in the ui-components popover

[pedrobonamin]

The large ui-components button equals to the default size of the button imported from @sanity/ui

[RitaDias]

Tested and double checked with the modal and everything looks good :)
The only thing I don't know a whole lot about is the setting up of the linting but it looks good to me as well!

[binoy14]

Good catch! thanks for fixing it