feat(cli): use auto-updates flag in init #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 11, 2024 11:05 PM (UTC)
|
cngonzalez
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
5538e15
to
9d1dc0a
Compare
cngonzalez
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
9d1dc0a
to
69395f5
Compare
cngonzalez
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
69395f5
to
2acba13
Compare
cngonzalez
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
2acba13
to
9c5d788
Compare
rexxars
reviewed
Sep 12, 2024
| if (typeof value !== 'boolean') { | ||
| throw new Error(`Expected boolean value for '${variableName}'`) | ||
| } | ||
| node.name = value.toString() |
There was a problem hiding this comment.
I don't like this approach - we're relying on the fact that babel won't validate that the name is valid. This identifier node should be replaced with a Literal node. I'll do a fix.
rexxars
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
6deceda
to
2e92243
Compare
rexxars
force-pushed
the
feat/sdx-1583/allow-no-auto-updates-in-init
branch
from
2e92243
to
bd5c9ad
Compare
ricokahler
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
looks good! i believe this should result in right CLI config
not sure if this was suggested yet, but it seems like we're reimplementing a lot of what babel template could solve but it may be more complicated with dependencies, typescript support, etc so feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we move to make auto-updates the default way of updating studios, we want to ensure that we give developers the option to maintain legacy behavior and keep to specific versions if they prefer.
This PR updates the
sanity initcommand to allow a--no-auto-updatesflag that will then be injected into the CLI configuration asautoUpdates: trueorautoUpdates: falseThis required a bit of refactoring of our template logic, since we previously only dealt with string variables. I've added another way of identifying the variables we're injecting, but happy to refactor if this is not ideal.
What to review
Are there any ways in which auto-updates might be undefined? Any gotchas in the AST parser?
Testing
I've added a test for this against Typescript -- if needed, I can repeat those tests for the other cases (Javascript, templates) but assume all will be consistent.
(No release notes because this feature is still in beta)