Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): single addon dataset context #7432

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Aug 29, 2024

Description

The addon dataset context will only be wrapped if it does not already exist. This is inkeeping with how many newer contexts are being defined, to avoid multiple separate contexts being nested

What to review

Testing

N/A

Notes for release

N/A

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:41am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:41am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:41am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:41am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 10:41am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Aug 29, 2024 10:43 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 12s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@jordanl17 jordanl17 marked this pull request as ready for review August 29, 2024 13:14
@jordanl17 jordanl17 requested a review from a team as a code owner August 29, 2024 13:14
@jordanl17 jordanl17 requested review from cngonzalez, juice49, binoy14, RitaDias, ricokahler, pedrobonamin and bjoerge and removed request for a team August 29, 2024 13:14
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing This Jordan ✅

@jordanl17 jordanl17 added this pull request to the merge queue Aug 30, 2024
Merged via the queue into next with commit 9da634e Aug 30, 2024
43 checks passed
@jordanl17 jordanl17 deleted the chore/corel=singleton-addon-dataset-context branch August 30, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants