Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add padding above the "Push to reload" button instead of below #7464

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

SimeonGriggs
Copy link
Contributor

@SimeonGriggs SimeonGriggs commented Sep 4, 2024

Description

Fixes this padding issue by moving it above the button instead of below. This screenshot shows the current state:

Screenshot 2024-09-04 at 09 59 21

Notes for release

Adjusts vertical padding around "Push to reload" button

@SimeonGriggs SimeonGriggs requested a review from a team as a code owner September 4, 2024 09:05
@SimeonGriggs SimeonGriggs requested review from juice49 and removed request for a team September 4, 2024 09:05
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:17am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:17am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:17am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:17am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 0:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 0:17am

Copy link
Contributor

github-actions bot commented Sep 4, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Component Testing Report Updated Sep 17, 2024 12:13 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 37s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

jordanl17
jordanl17 previously approved these changes Sep 4, 2024
Copy link
Member

@jordanl17 jordanl17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@juice49
Copy link
Contributor

juice49 commented Sep 4, 2024

This looks like a good quick fix. However, it seems like a mistake that we wrap a single Button component in a Stack at all. I'm assuming the "ready to update" copy was originally intended to appear inside the Stack so that the copy and the Button component would implicitly be given a gap.

It would be great to remove the redundant Stack and Box altogether (assuming the Box isn't necessary for the layout).

juice49
juice49 previously approved these changes Sep 4, 2024
@cngonzalez
Copy link
Member

cngonzalez commented Sep 6, 2024

This looks like a good quick fix. However, it seems like a mistake that we wrap a single Button component in a Stack at all. I'm assuming the "ready to update" copy was originally intended to appear inside the Stack so that the copy and the Button component would implicitly be given a gap.

It would be great to remove the redundant Stack and Box altogether (assuming the Box isn't necessary for the layout).

You're right on the money, there were quite a few last-minute changes on release day which drastically altered it from the original look / feel 😅

Notify AUS Studio Versions

I'll pull down this branch and see what cruft we can get rid of.

@rexxars rexxars changed the title Add padding above the "Push to reload" button instead of below fix: add padding above the "Push to reload" button instead of below Sep 10, 2024
@cngonzalez cngonzalez dismissed stale reviews from juice49 and jordanl17 via c49b36f September 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants