Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOY-12447] Android 12&13: User cannot share quotes/posts #3

Merged
merged 12 commits into from
Feb 8, 2023
Merged

[JOY-12447] Android 12&13: User cannot share quotes/posts #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
527ceff
Fix for https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plug…
bennimmo Jan 18, 2021
8bf99cd
Correct fix for https://github.com/EddyVerbruggen/SocialSharing-Phone…
bennimmo Jan 18, 2021
dd4ebbf
Merge pull request #1139 from bennimmo/master
EddyVerbruggen Jan 18, 2021
f20414e
bump
EddyVerbruggen Jan 18, 2021
b600d89
android 12 fix
Nov 30, 2021
4d310a3
Update plugin.xml
FilippiMatteo Jan 10, 2022
0c879e2
fix android exported=true
Jan 10, 2022
878a0b2
Merge remote-tracking branch 'origin/master'
Jan 10, 2022
5e9d58e
indend lines
Jan 10, 2022
18f6577
Merge pull request #1158 from FilippiMatteo/master
EddyVerbruggen Sep 7, 2022
3f6f455
bump
EddyVerbruggen Sep 7, 2022
b98dba6
Merge tag 'tags/6.0.4' into bugfix/JOY-12447
VioletaKirova-MentorMate Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.idea
.idea
*.iml
1 change: 1 addition & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.idea
*.iml
screenshots
tests
issue_template.md
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-x-socialsharing",
"version": "6.0.2",
"version": "6.0.4",
"description": "Share text, images (and other files), or a link via the native sharing widget of your device. Android is fully supported, as well as iOS 6 and up. WP8 has somewhat limited support.",
"cordova": {
"id": "cordova-plugin-x-socialsharing",
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="cordova-plugin-x-socialsharing"
version="6.0.2">
version="6.0.4">

<name>SocialSharing</name>

Expand Down
4 changes: 2 additions & 2 deletions src/android/nl/xservices/plugins/SocialSharing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
if (notEmpty(args.getString(0))) {
copyHintToClipboard(args.getString(0), "Instagram paste message");
}
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), "instagram", null, false, true);
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), "com.instagram.android", null, false, true, "com.instagram.share.handleractivity.ShareHandlerActivity");
} else if (ACTION_CAN_SHARE_VIA.equals(action)) {
return doSendIntent(callbackContext, args.getString(0), args.getString(1), args.getJSONArray(2), args.getString(3), args.getString(4), null, true, true);
} else if (ACTION_CAN_SHARE_VIA_EMAIL.equals(action)) {
Expand Down Expand Up @@ -271,7 +271,7 @@ public void run() {
final boolean hasMultipleAttachments = files.length() > 1;
final Intent sendIntent = new Intent(hasMultipleAttachments ? Intent.ACTION_SEND_MULTIPLE : Intent.ACTION_SEND);
final Intent receiverIntent = new Intent(cordova.getActivity().getApplicationContext(), ShareChooserPendingIntent.class);
final PendingIntent pendingIntent = PendingIntent.getBroadcast(cordova.getActivity().getApplicationContext(), 0, receiverIntent, PendingIntent.FLAG_UPDATE_CURRENT);
final PendingIntent pendingIntent = PendingIntent.getBroadcast(cordova.getActivity().getApplicationContext(), 0, receiverIntent, PendingIntent.FLAG_UPDATE_CURRENT|PendingIntent.FLAG_IMMUTABLE);
sendIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET);

try {
Expand Down