-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): implement sorting of config diff object #56
Conversation
Current coverage is
|
Will rebase and push again. |
return rules.sort(sortAlphabetically) | ||
} | ||
|
||
function transformIntoSortedRulesArray(allRulesArray) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the name allRulesArray
is not semantic, its and object
, may be you want to keep it rules
👍 after rebase and typo fix! |
My bad, clicked the wrong button by mistake. |
Merged, as coordinated with @sarbbottam |
Relates to #50