Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ecdsa support for native client #69

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add ecdsa support for native client #69

wants to merge 2 commits into from

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jun 28, 2024 •
edited
Loading

Closes #65

  • fix tests
  • try it manually to make sure it works
  • ensure existing rsa keys are renewed with the same key_alg=rsa
  • add configuration options for certbot client?
  • add tests

ruslandoga
ruslandoga commented Jun 30, 2024
View reviewed changes
lib/site_encrypt.ex
],
elliptic_curve: [
type: {:in, ["P-256", "P-384"]},
default: "P-256",
Copy link
Contributor Author

@ruslandoga ruslandoga Jun 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P-256 is fast: benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for ECDSA certificates in the native client
1 participant
@ruslandoga