Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let inspect() print nested, empty, bracketed lists. #1547

Merged
merged 5 commits into from
Dec 10, 2021
Merged

Let inspect() print nested, empty, bracketed lists. #1547

merged 5 commits into from
Dec 10, 2021

Conversation

Awjin
Copy link
Contributor

@Awjin Awjin commented Nov 4, 2021

@Awjin Awjin requested a review from nex3 November 4, 2021 23:56
@Awjin Awjin requested review from nex3 and removed request for nex3 December 3, 2021 22:56
nex3
nex3 reviewed Dec 3, 2021
View reviewed changes
lib/src/parse/keyframe_selector.dart Outdated Show resolved Hide resolved
pubspec.yaml Show resolved Hide resolved
nex3
nex3 approved these changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although as discussed offline let's wait to merge this until we've officially released 1.45.0.

@nex3 nex3 merged commit 1798a7c into main Dec 10, 2021
@nex3 nex3 deleted the nested-empty-list branch December 10, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@debug doesn't print nested empty lists
3 participants
@Awjin @nex3 @stof