Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the heuristic where long selector lists wouldn't be trimmed #2255

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented May 29, 2024

No description provided.

@nex3 nex3 requested a review from jathak May 29, 2024 00:19
Testing this against the `@extend`-heavy stylesheets in
vinceliuice/Colloid-gtk-theme, trimming everywhere actually *improves*
performance rather than reducing it.
@nex3 nex3 changed the title Use pubspec_parse dependency equality @nex3 Remove the heuristic where long selector lists wouldn't be trimmed May 29, 2024
@nex3 nex3 changed the title @nex3 Remove the heuristic where long selector lists wouldn't be trimmed Remove the heuristic where long selector lists wouldn't be trimmed May 29, 2024
@nex3 nex3 mentioned this pull request May 29, 2024
1 task
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than needing to bump the version

lib/src/extend/functions.dart Outdated Show resolved Hide resolved
@nex3 nex3 merged commit ecff05d into main Jun 11, 2024
34 checks passed
@nex3 nex3 deleted the trim-everywhere branch June 11, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants