Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RbConfig::CONFIG['SOEXT']
would be better, but DLEXT is used as libsass is compiled by mkmf (Link C/C++ stdlib statically for binary gems #127).
RbConfig::MAKEFILE_CONFIG['DLEXT']
instead of justRbConfig::CONFIG['DLEXT']
so it's also correct on JRuby and not 'jar'. See
https://github.com/rake-compiler/rake-compiler/blob/f808dd7a/lib/rake/extensiontask.rb#L41
for C extensions. For example, TruffleRuby 19.3.0 uses .dylib on macOS.
This allows
sassc
to work again on TruffleRuby on macOS: oracle/truffleruby#1819cc @bolandrm @glebm