Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore strip symbols #184

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Restore strip symbols #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@
$srcs = Dir['libsass/src/**/*.{c,cpp}']
end

# libsass.bundle malformed object (unknown load command 7) on Mac OS X
# See https://github.com/sass/sassc-ruby/pull/174
if enable_config('strip', RbConfig::CONFIG['host_os'].downcase !~ /darwin/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment with a link to #174

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

I would like to test it, but all tests passed on OSX (multiple versions) even without this change :-(
https://travis-ci.org/sass/sassc-ruby/builds/652242014?utm_source=github_status&utm_medium=notification

MakeMakefile::LINK_SO << "\nstrip -x $@"
end

# Don't link libruby.
$LIBRUBYARG = nil

Expand Down