Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option "output_path" added. #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Harald-LB
Copy link

The native library has a function sass_option_set_output_path which is attached to ruby in native_context_api.rb. But in engine.rb this option is not set (why?).
However to produce correct source maps, the output path must be known to the native library.

The use of the parameters :source_map_file, :filename and :output_path is shown in the test_source_map_filenames test in file test/engine_test.rb.

By the way, all these parameters need to be documented. Where is the right place to put this?

@bolandrm
Copy link
Member

Thanks for the PR! For parameter documentation, I think it would be good to start a new section under usage.

@brendon
Copy link

brendon commented Aug 2, 2019

This is a great addition. Is there any reason why this has stalled? Without this option, source maps where the output file isn't in the same directory as the input file don't appear to be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants