Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the circular dependency between diktat-rules and diktat-ruleset #1481

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Remove the circular dependency between diktat-rules and diktat-ruleset #1481

merged 4 commits into from
Jul 28, 2022

Conversation

0x6675636b796f75676974687562
Copy link
Member

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 commented Jul 28, 2022 •
edited
Loading

What's done:

@0x6675636b796f75676974687562
Remove the circular dependency between diktat-rules and `diktat-rul…
5277177 
…eset`

### What's done:

 * Now it's possible to run `mvn clean install` w/o skipping tests.
 * Reverted ad66a04 (was useless in the 1st
   place).
 * Reverted ad66a04 (no longer necessary).
 * Partially reverted 54c8cce (no longer
   necessary).
 * See #1478.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added infrastructure Issues related to building the project, CI/CD, deployments etc. tests Improve testing labels Jul 28, 2022
@0x6675636b796f75676974687562
Make diKTat happy
b5411e5 
### What's done:

 * See #1478.
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #1481 (bc9a602) into master (4a3e5e1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1481   +/-   ##
=========================================
  Coverage     82.96%   82.96%           
  Complexity     2579     2579           
=========================================
  Files           111      111           
  Lines          7708     7708           
  Branches       2111     2111           
=========================================
  Hits           6395     6395           
  Misses          418      418           
  Partials        895      895
Flag Coverage Δ
unittests 82.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3e5e1...bc9a602. Read the comment docs.

petertrr
petertrr reviewed Jul 28, 2022
View reviewed changes
diktat-rules/pom.xml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 318 tests   1 302 ✔️  1m 4s ⏱️
   161 suites       16 💤
   161 files           0 ❌

Results for commit b5411e5.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 332 tests   1 317 ✔️  3m 7s ⏱️
   162 suites       15 💤
   162 files           0 ❌

Results for commit b5411e5.

@0x6675636b796f75676974687562
Make diKTat happy
82a0074 
### What's done:

 * See #1478.
@0x6675636b796f75676974687562
Make diKTat happy
bc9a602 
### What's done:

 * See #1478.
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 deleted the infra/andrey.shcheglov/misc branch July 28, 2022 16:12
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked an issue Jul 28, 2022 that may be closed by this pull request
ISE: "No runnable rules found. Please ensure that at least one is enabled" when running smoke tests during the release procedure #1478
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertrr petertrr petertrr approved these changes

@nulls nulls Awaiting requested review from nulls

@Cheshiriks Cheshiriks Awaiting requested review from Cheshiriks

@orchestr7 orchestr7 Awaiting requested review from orchestr7

Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
infrastructure Issues related to building the project, CI/CD, deployments etc. tests Improve testing
Projects
None yet
Milestone
No milestone
2 participants
@0x6675636b796f75676974687562 @petertrr