Implement verification functions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firgeis
changed the title
|
@smimram Any chance I can get this reviewed? |
|
This is really desirable for platforms where the certs are outdated. |
|
but @Firgeis I think you need to separate the branch there is additional commits besides of the ones mentioned by the PR |
|
You are right @EduardoRFS, but I think it is worth including and doesn't conflict with the others. |
|
I've been using this branch in Piaf and it's been working well. Would appreciate a review here and potentially a release. |
anmonteiro
added a commit
to Firgeis/ocaml-ssl
that referenced
this pull request
Jul 24, 2022
anmonteiro
added a commit
that referenced
this pull request
Jul 24, 2022
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Aug 12, 2022
CHANGES: - Add a few verification functions (savonet/ocaml-ssl#71): - `add_extra_chain_cert` to send additional chain certificates to the peer. - `add_cert_to_store`: to allow verification of the peer certificate CA. - `set_ip`: sets the expected IP address to be verified on a SSL socket. - Improve `use_certificate_from_string` (savonet/ocaml-ssl#71) to read any type of key (rather than just RSA). - Fix a segmentation fault in the ALPN selection callback under OCaml 5 (savonet/ocaml-ssl#89). - Audit the C FFI and add `CAMLparamX` and `CAMLreturn` calls (savonet/ocaml-ssl#90).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pair of verification functions that accept a parsed PEM certificate.
add_extra_chain_cert to send additional chain certs to the peer.
add_cert_to_store to allow verification of the peer certificate CA. This function combines libssl SSL_CTX_get_cert_store and X509_STORE_add_cert so as not to expose the internal store unnecessarily.
Also improves use_certificate_from_string to read any type of key instead of just RSA