Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbc-v3: new FBC constants for fbcVariableType are named inconsistently #251

Closed
matthiaskoenig opened this issue Jul 15, 2022 · 2 comments · Fixed by #264
Closed

fbc-v3: new FBC constants for fbcVariableType are named inconsistently #251

matthiaskoenig opened this issue Jul 15, 2022 · 2 comments · Fixed by #264

Comments

@matthiaskoenig
Copy link

I just noticed that the constants for FBC are not named consistently.

The existing constants are for objective.type

libsbml.OBJECTIVE_TYPE_MINIMIZE
libsbml.OBJECTIVE_TYPE_MAXIMIZE

Whereas the new constant for fbcVariableType are prefixed with FBC and the _ separation is different

libsbml.FBC_FBCVARIABLETYPE_LINEAR
libsbml.FBC_FBCVARIABLETYPE_QUADRATIC
libsbml.FBC_FBCVARIABLETYPE_INVALID

These should probably be

libsbml.FBC_VARIABLE_TYPE_LINEAR
libsbml.FBC_VARIABLE_TYPE_QUADRATIC
libsbml.FBC_VARIABLE_TYPE_INVALID
@fbergmann
Copy link
Member

I'm fine with that change. Given that FBC v3 has not been accepted yet, I would prefer to leave that renaming until we have collected all changes you still need.

@matthiaskoenig
Copy link
Author

Perfect.

This was referenced Aug 5, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fbc v3 fixes sbmlteam/libsbml
Fix fbc v3 issues sbmlteam/libsbml
2 participants
@matthiaskoenig @fbergmann